Ticket #41 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Oracle 10g generates bad UPDATE/DELETE DAO's from SVN 6/26/06

Reported by: nowen@… Owned by: dhughes
Priority: normal Milestone:
Component: Reactor - DAO Version: 1.0
Severity: critical Keywords:
Cc:

Description

Insert's and Read's appear to work but I get Update functions like this in my /reactor/projects/Dao/AddressDao.cfc:

	<cffunction name="update" access="public" hint="I update a ADDRESS object." output="false" returntype="void">
		<cfargument name="to" hint="I am the transfer object for ADDRESS which will be used to update a record in the table." required="yes" type="reactor.project..To.ADDRESSTo" />
		<cfset var Convention = getConventions() />
		<cfset var qUpdate = 0 />
				
		<cfquery name="qUpdate" datasource="#_getConfig().getDsn()#" username="#_getConfig().getUsername()#" password="#_getConfig().getPassword()#">
			UPDATE #Convention.FormatObjectName(getObjectMetadata())#
			SET 
			
			WHERE
			
		</cfquery>
	</cffunction>

I am able to run my application to populate the page but run into errors when I try to save().

Delete looks the same way:

	<cffunction name="delete" access="public" hint="I delete a record in the ADDRESS table." output="false" returntype="void">
		<cfargument name="to" hint="I am the transfer object for ADDRESS which will be used to delete from the table." required="yes" type="reactor.project..To.ADDRESSTo" />
		<cfset var Convention = getConventions() />
		<cfset var qDelete = 0 />
		
		<cfquery name="qDelete" datasource="#_getConfig().getDsn()#" username="#_getConfig().getUsername()#" password="#_getConfig().getPassword()#">
			DELETE FROM #Convention.FormatObjectName(getObjectMetadata())#
			WHERE
			
		</cfquery>
		
	</cffunction>

This pattern is repeated in all my DAO's(7 or so).

Snippet of reactor.xml:

        <config>
		<dsn value="wastefull" />
		<type value="oracle" />
		<mapping value="/Applications/wdireactor/model/reactor/" />
		<mode value="development" />
	</config>

Change History

Changed 4 years ago by bbowden

  • status changed from new to closed
  • resolution set to fixed

Per e-mail with nowen@…: Previous fix corrected this problem. Ticket can be closed.

Note: See TracTickets for help on using tickets.