Ticket Navigation

← Previous Ticket
Next Ticket →

Ticket #62 (closed enhancement: wontfix)

Opened 2 years ago

Last modified 1 year ago

Return all errors including children's in a single array.

Reported by:	rblatz	Owned by:	dhughes
Type:	enhancement	Priority:	normal
Milestone:	Reactor 2.0 Alpha	Component:	Reactor - Record
Version:		Severity:	normal
Keywords:	Error reporting, Record, ErrorCollection	Cc:

Description

I was unable to find an easy way to use the built in validation when working with linked tables. I was able to validate all the Records with one validate statement, but was unable to return all the translated errors without checking each child object by hand. I propose that a getAllErrors method be added to the abstractRecord.cfc. I have attached a possible implementation of this.

Attachments

reactor_getallerrors.cfm (1.3 kB) - added by rblatz 2 years ago.

Change History

Changed 2 years ago by mark.stanton@…

A couple of points around this:

It seems to be duplicating what is already going on in ErrorCollection.merge() with two main differences:
- it deals with translated errors rather than the dictionary error codes
- it is recusive

I'm not sure either of these things is a good idea.

We do need to get to the translated errors (as mentioned at http://trac.reactorframework.org/reactor/ticket/61), but we don't want these at the expense of the dictionary error codes (i.e. we need both).

Also recursion sacres me a bit - imagine this situtation: A Contract hasOne User, the User hasOne Agency, the Agency hasMany Users, each User hasMany Contracts. Recursive validation in this situation would not be desirable.

Cheers

Mark

follow-up: ↓ 4 Changed 2 years ago by mark.stanton@…

More.... I've knocked together a view level solution that is working for us. I still think that #61 should be fixed if possible, but for the moment this workaround seems to be ok:

errorMessage.cfm (called as pagelet):

<cfparam name="attributes.record" type="any">
<cfset reactor = application.atii.appLoader.getAppManager().getPropertyManager().getProperty('serviceFactory').getBean('reactor')>
<cfset request.dictionaries = structNew()>

<cfoutput>
	<cfif attributes.record.validated() AND attributes.record.hasErrors()>
		<cfset errorCollection = attributes.record._getErrorCollection()>
		<cfset errorCodes = errorCollection.getErrors()>
		<cfset errorMsgs = errorCollection.getTranslatedErrors()>
		<div id="error-message">
		<p>Your form has #errorCollection.count()# errors</p>
		<ul>
			<cfloop from="1" to="#arrayLen(errorMsgs)#" index="i">
				<cfif errorMsgs[i] EQ errorCodes[i]>
					<cfset alias = listFirst(errorCodes[i],'.')>
					<cfparam name="request.dictionaries" default="#structNew()#">
					<cfparam name="request.dictionaries[alias]" default="#reactor.createDictionary(alias)#">
					<li>#request.dictionaries[alias].getValue(errorMsgs[i])#</li>
				<cfelse>
					<li>#errorMsgs[i]#</li>
				</cfif>
			</cfloop>
		</ul>
		</div>
	</cfif>
</cfoutput>

This is then dropped into any template that requires validation output like so:

<cfimport taglib="/atii/pagelets/form" prefix="form">
<ui:errorMessage record="#request.objCNRecord#">

Changed 1 year ago by badya

Changed 1 year ago by badya

Note: See TracTickets for help on using tickets.

Download in other formats:

Ticket Navigation

Ticket #62 (closed enhancement: wontfix)

Return all errors including children's in a single array.

Description

Attachments

Change History

Changed 2 years ago by rblatz

Changed 2 years ago by mark.stanton@…

Changed 2 years ago by mark.stanton@…

follow-up: ↓ 4 Changed 2 years ago by mark.stanton@…

in reply to: ↑ 3 Changed 2 years ago by mark.stanton@…

Changed 2 years ago by dhughes

Changed 2 years ago by dhughes

Changed 1 year ago by badya

Changed 1 year ago by badya

Download in other formats: